Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Setting] DialogScreen isShowing 제거 #43

Merged
merged 1 commit into from
Feb 4, 2024
Merged

[Setting] DialogScreen isShowing 제거 #43

merged 1 commit into from
Feb 4, 2024

Conversation

ajou4095
Copy link
Collaborator

@ajou4095 ajou4095 commented Feb 4, 2024

설명

  • isShowing 을 밖으로 뺐습니다.

참고

체크리스트

  • : 빌드 테스트를 진행하셨나요?
  • : 실제 기기에서 테스트를 진행하셨나요?

@ajou4095 ajou4095 requested a review from jinuemong as a code owner February 4, 2024 14:36
jinuemong
jinuemong approved these changes Feb 4, 2024
View reviewed changes
Copy link
Collaborator

@jinuemong jinuemong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@ajou4095 ajou4095 merged commit 2a3acf0 into main Feb 4, 2024
1 check passed
@ajou4095 ajou4095 deleted the setting-#43 branch February 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinuemong jinuemong jinuemong approved these changes

Assignees
No one assigned
Labels
develop: refactoring priority: medium state: in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajou4095 @jinuemong